Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jk/axis elements #2527

Merged
merged 1 commit into from
Dec 27, 2022
Merged

jk/axis elements #2527

merged 1 commit into from
Dec 27, 2022

Conversation

jkrumbiegel
Copy link
Member

@jkrumbiegel jkrumbiegel commented Dec 27, 2022 •
edited
Loading

  • add elements dict back to Axis

@MakieBot
Copy link
Collaborator

MakieBot commented Dec 27, 2022 •
edited
Loading

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie – – – – –
master – – – – –
evaluation – – – – –
CairoMakie 26.28s (26.19, 26.36) 0.07+- 16.36s (16.25, 16.45) 0.07+- 2.50s (2.48, 2.52) 0.01+- 10.50ms (10.43, 10.59) 0.06+- 4.14ms (4.06, 4.25) 0.06+-
master 26.33s (26.19, 26.44) 0.10+- 16.30s (16.19, 16.38) 0.08+- 2.49s (2.46, 2.51) 0.02+- 10.54ms (10.46, 10.63) 0.06+- 4.21ms (4.16, 4.26) 0.04+-
evaluation -0.19%, -0.05s invariant (-0.58d, 0.30p, 0.08std) +0.34%, 0.06s invariant (0.78d, 0.17p, 0.07std) +0.43%, 0.01s invariant (0.72d, 0.20p, 0.01std) -0.38%, -0.04ms invariant (-0.70d, 0.21p, 0.06std) -1.69%, -0.07ms faster ✓ (-1.50d, 0.02p, 0.05std)
WGLMakie 38.15s (37.82, 38.32) 0.16+- 27.99s (27.60, 28.29) 0.24+- 42.68s (42.18, 44.39) 0.77+- 14.84ms (14.33, 15.23) 0.29+- 2.72s (2.65, 2.77) 0.04+-
master 37.95s (37.71, 38.36) 0.23+- 27.79s (27.52, 28.35) 0.30+- 42.34s (41.64, 42.78) 0.39+- 14.00ms (13.59, 14.33) 0.24+- 2.55s (2.53, 2.58) 0.02+-
evaluation +0.52%, 0.2s invariant (0.99d, 0.09p, 0.20std) +0.73%, 0.2s invariant (0.75d, 0.19p, 0.27std) +0.80%, 0.34s invariant (0.56d, 0.32p, 0.58std) +5.70%, 0.85ms slower❌ (3.14d, 0.00p, 0.27std) +6.17%, 0.17s slower❌ (5.12d, 0.00p, 0.03std)

@jkrumbiegel jkrumbiegel merged commit 2fcee32 into master Dec 27, 2022
@jkrumbiegel jkrumbiegel deleted the jk/axis-elements branch December 27, 2022 11:05
t-bltg pushed a commit to t-bltg/Makie.jl that referenced this pull request Dec 31, 2022
@jkrumbiegel @t-bltg
jk/axis elements (MakieOrg#2527)
a41fa0b 
add elements dict back to Axis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkrumbiegel @MakieBot